Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

835 extend caption editing area UI #491

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

dsding2
Copy link
Contributor

@dsding2 dsding2 commented Nov 11, 2024

Allows editing of starting and ending timestamps for captions and descriptions.

@dsding2
Copy link
Contributor Author

dsding2 commented Nov 11, 2024

Also implements the api to add a new caption, although frontend implementation for that isn't ready

@angrave
Copy link
Collaborator

angrave commented Nov 11, 2024

Unit tests failed ; please review + fix and push an update
Error: /home/runner/work/WebAPI/WebAPI/UnitTests/ClassTranscribeServer/ControllerTests/CaptionsControllerTest.cs(23,31): error CS7036: There is no argument given that corresponds to the required parameter 'logger' of 'CaptionsController.CaptionsController(WakeDownloader, CTDbContext, CaptionQueries, UserUtils, ILogger)' [/home/runner/work/WebAPI/WebAPI/UnitTests/UnitTests.csproj]

Copy link
Collaborator

@angrave angrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angrave angrave merged commit 86b1a17 into staging Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants